lint 0.0.2-preview.1
Lint rules for Zena source, each with a fix
lint#
Lint rules for Zena source code, each with an automated fix. The compiler and type checker drive every rule, and when a fix is applied it is type-checked again before it is kept.
Usage#
Command Line#
zena lint [--fix] [--only a,b] [--skip a,b] <paths...>
zena lint --list-rules
A path is a .zena file or a directory, searched for them. Without --fix the command prints each finding as path:line:column: message [rule] and exits 1 when there is one; with --fix it rewrites the files. -v on the command lists every fix and the text of any rejected one.
The language server (zena lsp) publishes the findings as warnings and offers each as a quick fix, plus a source.fixAll.zena code action for the whole file.
Library API#
import { LintOptions, lintFile } from 'lint';
import { Project } from 'lint/checking';
import { allRules } from 'lint/rules';
let project = new Project();
let options = new LintOptions(allRules());
let report = await lintFile(project, 'src/main.zena', options);
Rules#
| Rule | Rewrite |
|---|---|
function-declaration |
top-level let f = (…) => … → function f(…) { … } |
unnecessary-cast |
x as T where x: T → x (from the checker's warning, less contextually typed operands) |
unnecessary-optional-chain |
x?.f, x?[i], f?(…) on a non-nullable target → x.f, x[i], f(…) |
unnecessary-annotation |
let x: T = e with e: T; return types the body implies; callback parameter types |
collection-literal |
new Array<T>() + push runs → growable<T>([…]); new Map<K, V>() + []= → {k => v} |
if-initializer |
var x = d; if (c) { x = a; } → let x = if (c) a else d |
nullish |
if (x != null) x else d → x ?? d; if (x != null) x.f else null → x?.f |
match-to-if |
one- and two-arm match → if, if (x is T), if (let P = x) |
else-if |
else { if (…) { … } } → else if (…) { … } |
for-in |
index loops that read only xs[i] → for (let x in xs) |
boolean-return |
if (c) { return true; } return false; → return c;; if (c) true else false → c |
template-literal |
three or more +-joined strings → a template literal |
console-to-string |
console.log(`${x}`) and console.log(i32ToString(x)) → console.log(x) |
arrow-body |
(x) => { return e; } → (x) => e |
prefer-let |
var never assigned again → let |
immutable-field |
var field nothing assigns → immutable field (#private, or the class is not exported) |
empty-constructor |
new() {} on a class with no other constructor → removed; the default is synthesized |
Libraries#
lint/lint/lint— lint driver (lintFile,lintSource,LintOptions,FileReport)lint/checking— compiler project wrapper and overlay host (Project,CheckedFile)lint/checked— checked module wrapper (CheckedFile)lint/rules— rule registry (allRules,ruleNamed)lint/rule— rule runner (NamedRule,proposeEdits,messageOf)lint/context— rule traversal context (RuleContext)lint/source— byte-range edits (Edit,applyEdits,columnOf)lint/files—.zenafile discovery (collectZenaFiles)
License#
MIT
2.2 KiB
Raw
/**
* `x as T` where `x` already has type `T` becomes `x`.
*
* The checker finds these (`warnUnnecessaryCasts`); this rule removes
* the ones that are safe to remove. The checker measures the operand
* with the cast's target as its context, so `[] as Array<i32>` is
* reported too — there the cast is doing the typing, and the operand is
* left alone (`isContextuallyTyped`). Grouping parentheses that existed
* only for the cast, `(x as T).f`, go with it.
*/
import { Node, AsExpression, MemberExpression, IndexExpression, CallExpression } from 'compiler/ast';
import { walkEnter } from 'compiler/visitor';
import { DiagnosticCode } from 'compiler/compiler';
import { RuleContext } from '../context.zena';
import { skipWhitespace, skipWhitespaceBack } from '../source.zena';
let LEFT_PAREN = 40;
let RIGHT_PAREN = 41;
export function unnecessaryCasts(ctx: RuleContext): void {
let warnings = ctx.diagnosticsOf(DiagnosticCode.UnnecessaryCast);
if (warnings.length == 0) {
return;
}
let castsByStart = new Map<i32, AsExpression>();
walkEnter(ctx.ast, (n) => {
if (n is AsExpression) {
castsByStart[ctx.recordedStart(n)] = n;
}
});
for (let warning in warnings) {
let location = warning.location;
if (location == null) {
continue;
}
if (let (true, cast) = castsByStart.get(location.start)) {
if (ctx.isContextuallyTyped(cast.expression)) {
continue;
}
var start = ctx.start(cast);
var end = ctx.end(cast);
let parent = ctx.parent(cast);
if (parent != null && isAccessOf(parent, cast)) {
let open = skipWhitespaceBack(ctx.source, start);
let close = skipWhitespace(ctx.source, end);
if (open >= 0 && ctx.source.getByteAt(open) == LEFT_PAREN &&
close < ctx.source.length && ctx.source.getByteAt(close) == RIGHT_PAREN) {
start = open;
end = close + 1;
}
}
ctx.replaceRange(start, end, ctx.text(cast.expression));
}
}
}
/** Whether `parent` is `(cast).x`, `(cast)[i]` or `(cast)(…)`. */
function isAccessOf(parent: Node, cast: AsExpression): boolean {
return match (parent) {
case MemberExpression {object}: object === cast
case IndexExpression {object}: object === cast
case CallExpression {callee}: callee === cast
case _: false
};
}
- compiler compiler.zena-lang.pkg.zena-lang.dev 0.0.2-preview.1
| Version | Published | Dependencies | Approved by |
|---|---|---|---|
| 0.0.2-preview.1 | 2026-11-19 |
|
|